chrome/browser/component_updater/test/component_patcher_unittest.cc - Issue 420503002: Componentize component_updater: Decouple in-process DeltaUpdateOp from out-of-process version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/test/component_patcher_unittest.cc

Issue 420503002: Componentize component_updater: Decouple in-process DeltaUpdateOp from out-of-process version. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/test/component_patcher_unittest.h ('k') | chrome/browser/component_updater/test/test_configurator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/test/component_patcher_unittest.cc

diff --git a/chrome/browser/component_updater/test/component_patcher_unittest.cc b/chrome/browser/component_updater/test/component_patcher_unittest.cc

index d220d9d28575c4573ab223f5dd59c1988ca2b1b1..605fc94192bdb7bcfdfeb889f973e5a9058d8a01 100644

--- a/chrome/browser/component_updater/test/component_patcher_unittest.cc

+++ b/chrome/browser/component_updater/test/component_patcher_unittest.cc

@@ -92,7 +92,6 @@ TEST_F(ComponentPatcherOperationTest, CheckCreateOperation) {

input_dir_.path(),

unpack_dir_.path(),

NULL,

- true,

base::Bind(&TestCallback::Set, base::Unretained(&callback)),

task_runner_);

base::RunLoop().RunUntilIdle();

@@ -123,7 +122,6 @@ TEST_F(ComponentPatcherOperationTest, CheckCopyOperation) {

input_dir_.path(),

unpack_dir_.path(),

installer_.get(),

- true,

base::Bind(&TestCallback::Set, base::Unretained(&callback)),

task_runner_);

base::RunLoop().RunUntilIdle();

@@ -153,12 +151,12 @@ TEST_F(ComponentPatcherOperationTest, CheckCourgetteOperation) {

command_args->SetString("patch", "binary_courgette_patch.bin");

TestCallback callback;

- scoped_refptr<DeltaUpdateOp> op = CreateDeltaUpdateOp("courgette");

+ scoped_refptr<DeltaUpdateOp> op =

+ CreateDeltaUpdateOp("courgette", NULL /* out_of_process_patcher */);

op->Run(command_args.get(),

input_dir_.path(),

unpack_dir_.path(),

installer_.get(),

- true,

base::Bind(&TestCallback::Set, base::Unretained(&callback)),

task_runner_);

base::RunLoop().RunUntilIdle();

@@ -188,12 +186,12 @@ TEST_F(ComponentPatcherOperationTest, CheckBsdiffOperation) {

command_args->SetString("patch", "binary_bsdiff_patch.bin");

TestCallback callback;

- scoped_refptr<DeltaUpdateOp> op = CreateDeltaUpdateOp("bsdiff");

+ scoped_refptr<DeltaUpdateOp> op =

+ CreateDeltaUpdateOp("bsdiff", NULL /* out_of_process_patcher */);

op->Run(command_args.get(),

input_dir_.path(),

unpack_dir_.path(),

installer_.get(),

- true,

base::Bind(&TestCallback::Set, base::Unretained(&callback)),

task_runner_);

base::RunLoop().RunUntilIdle();