Componentize component_updater: Decouple in-process DeltaUpdateOp from out-of-process version.

chrome/browser/component_updater/test/component_patcher_unittest.cc

Index: chrome/browser/component_updater/test/component_patcher_unittest.cc
diff --git a/chrome/browser/component_updater/test/component_patcher_unittest.cc b/chrome/browser/component_updater/test/component_patcher_unittest.cc
index d220d9d28575c4573ab223f5dd59c1988ca2b1b1..27c888bbeaf0a7b728f42dd5b5cf2d96d58075ff 100644
--- a/chrome/browser/component_updater/test/component_patcher_unittest.cc
+++ b/chrome/browser/component_updater/test/component_patcher_unittest.cc
@@ -13,6 +13,7 @@
 #include "base/values.h"
 #include "chrome/browser/component_updater/component_patcher.h"
 #include "chrome/browser/component_updater/component_patcher_operation.h"
+#include "chrome/browser/component_updater/component_patcher_operation_factory.h"
 #include "chrome/browser/component_updater/component_updater_service.h"
 #include "chrome/browser/component_updater/test/component_patcher_unittest.h"
 #include "chrome/browser/component_updater/test/test_installer.h"
@@ -92,7 +93,6 @@ TEST_F(ComponentPatcherOperationTest, CheckCreateOperation) {
           input_dir_.path(),
           unpack_dir_.path(),
           NULL,
-          true,
           base::Bind(&TestCallback::Set, base::Unretained(&callback)),
           task_runner_);
   base::RunLoop().RunUntilIdle();
@@ -123,7 +123,6 @@ TEST_F(ComponentPatcherOperationTest, CheckCopyOperation) {
           input_dir_.path(),
           unpack_dir_.path(),
           installer_.get(),
-          true,
           base::Bind(&TestCallback::Set, base::Unretained(&callback)),
           task_runner_);
   base::RunLoop().RunUntilIdle();
@@ -153,12 +152,13 @@ TEST_F(ComponentPatcherOperationTest, CheckCourgetteOperation) {
   command_args->SetString("patch", "binary_courgette_patch.bin");
 
   TestCallback callback;
-  scoped_refptr<DeltaUpdateOp> op = CreateDeltaUpdateOp("courgette");
+  scoped_ptr<DeltaUpdateOpFactory> factory(
+      CreateDeltaUpdateOpFactory(true /* in_process */));

[waffles, 2014/07/31 21:54:27]

Am I correct in thinking that this true no longer needs to be here?

[tommycli, 2014/08/04 20:25:14]

Done.

+  scoped_refptr<DeltaUpdateOp> op = factory->CreateDeltaUpdateOp("courgette");
   op->Run(command_args.get(),
           input_dir_.path(),
           unpack_dir_.path(),
           installer_.get(),
-          true,
           base::Bind(&TestCallback::Set, base::Unretained(&callback)),
           task_runner_);
   base::RunLoop().RunUntilIdle();
@@ -188,12 +188,13 @@ TEST_F(ComponentPatcherOperationTest, CheckBsdiffOperation) {
   command_args->SetString("patch", "binary_bsdiff_patch.bin");
 
   TestCallback callback;
-  scoped_refptr<DeltaUpdateOp> op = CreateDeltaUpdateOp("bsdiff");
+  scoped_ptr<DeltaUpdateOpFactory> factory(
+      CreateDeltaUpdateOpFactory(true /* in_process */));
+  scoped_refptr<DeltaUpdateOp> op = factory->CreateDeltaUpdateOp("bsdiff");
   op->Run(command_args.get(),
           input_dir_.path(),
           unpack_dir_.path(),
           installer_.get(),
-          true,
           base::Bind(&TestCallback::Set, base::Unretained(&callback)),
           task_runner_);
   base::RunLoop().RunUntilIdle();