Chromium Code Reviews Chromium Code Reviews
Issue
420483002:
Revert of Remove 2 calls to paintInvalidationForWholeRenderer (Closed)
DescriptionRevert of Remove 2 calls to paintInvalidationForWholeRenderer (https://codereview.chromium.org/396073002/)
(and follow-up rebaselines)
Reason for revert:
This change is plain wrong as <body> and <html> can have different coordinate spaces (e.g. if either has a transform).
Thanks to Elliott to pointing this out.
Original issue's description:
> Remove 2 calls to paintInvalidationForWholeRenderer
>
> These calls were needed as we can make the body or the
> document element's background bleed into the canvas (ie
> replacing the FrameView's background). However the logic
> was working around the fact that
> clippedOverflowRectForPaintInvalidation didn't account for
> the previous cases.
>
> The whole logic works as the 2 renderers where this happens
> share the same coordinate space as the viewport. The tests
> are all invalidating as much, we just got rid of some stray
> invalidations.
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178605
TBR=leviw@chromium.org,dsinclair@chromium.org
NOTREECHECKS=true
NOTRY=true
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178857
Patch Set 1 #Patch Set 2 : Better revert. #Messages
Total messages: 7 (0 generated)
|
