chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.mm - Issue 420413002: Ensure dialogs are centered on browser windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.mm

Issue 420413002: Ensure dialogs are centered on browser windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: test works Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_private.mm ('k') | chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.mm

diff --git a/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.mm b/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.mm

index 92c02fcbab7b1e3e14b083ea42331cd5c1e498a5..c408dcfd0c064ae86bede07e33947f3e5c066873 100644

--- a/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.mm

+++ b/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.mm

@@ -9,6 +9,7 @@

#include "base/logging.h"

#import "chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet.h"

#include "chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_info.h"

+#import "chrome/browser/ui/cocoa/tabs/tab_strip_controller.h"

namespace {

@@ -243,7 +244,7 @@ NSValue* GetKeyForParentWindow(NSWindow* parent_window) {

}

- (NSRect)overlayWindowFrameForParentView:(NSView*)parentView {

- NSRect viewFrame = [parentView convertRect:[parentView bounds] toView:nil];

+ NSRect viewFrame = GetSheetParentBoundsForParentView(parentView);

id<NSWindowDelegate> delegate = [[parentView window] delegate];

if ([delegate respondsToSelector:@selector(window: