Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3457)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 420413002: Ensure dialogs are centered on browser windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
index 6a6a4f0bea3565b562db7358d194b799c001ab11..0a39770740065d023fbef887aed3ee095008082a 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
@@ -33,7 +33,6 @@
#import "chrome/browser/ui/cocoa/profiles/avatar_icon_controller.h"
#import "chrome/browser/ui/cocoa/status_bubble_mac.h"
#import "chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h"
-#import "chrome/browser/ui/cocoa/tabs/tab_strip_controller.h"
#import "chrome/browser/ui/cocoa/tabs/tab_strip_view.h"
#import "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
#import "chrome/browser/ui/cocoa/version_independent_window.h"
@@ -287,20 +286,6 @@ willPositionSheet:(NSWindow*)sheet
// Normally, we don't need to tell the toolbar whether or not to show the
// divider, but things break down during animation.
[toolbarController_ setDividerOpacity:[self toolbarDividerOpacity]];
-
- // Update the position of the active constrained window sheet. We force this
- // here because the |sheetParentView| may not have been resized (e.g., to
- // prevent jank during a fullscreen mode transition), but constrained window
- // sheets also compute their position based on the bookmark bar and toolbar.
- content::WebContents* const activeWebContents =
- browser_->tab_strip_model()->GetActiveWebContents();
- NSView* const sheetParentView = activeWebContents ?
- GetSheetParentViewForWebContents(activeWebContents) : nil;
- if (sheetParentView) {
- [[NSNotificationCenter defaultCenter]
- postNotificationName:NSViewFrameDidChangeNotification
- object:sheetParentView];
- }
}
- (CGFloat)floatingBarHeight {

Powered by Google App Engine
This is Rietveld 408576698