Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Issue 420393006: Fix a lint issue with Desktop.java. (Closed)

Created:
6 years, 4 months ago by Sungmann Cho
Modified:
6 years, 4 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix a lint issue with Desktop.java. Currently, the lint warns at: Error: Field requires API level 19 (current min is 14): android.view.View#SYSTEM_UI_FLAG_IMMERSIVE_STICKY [InlinedApi] So we need to add @SuppressLint to suppress this lint error. BUG=327768 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287466

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/Desktop.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sungmann Cho
Please take a look. Thanks!
6 years, 4 months ago (2014-07-30 02:36:49 UTC) #1
garykac
lgtm
6 years, 4 months ago (2014-08-04 20:59:52 UTC) #2
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 4 months ago (2014-08-04 21:02:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/420393006/1
6 years, 4 months ago (2014-08-04 21:04:33 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-04 21:53:52 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 05:45:19 UTC) #6
Message was sent while issue was closed.
Change committed as 287466

Powered by Google App Engine
This is Rietveld 408576698