Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 420383002: Changes analyzer to search for targets (Closed)

Created:
6 years, 4 months ago by sky
Modified:
6 years, 4 months ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Changes analyzer to search for targets Here's a list of the changes: . I'm changing input file to be a JSON file. This allows for passing in more information, such as the set of targets to search for. . Changing output format to be JSON as well. This allows for more structure in outputting other random data. I'm a bit iffy on whether this is good, but it's requested by the recipes side of things which uses analyzer. . You can now specify a set of targets to search for in addition to files. This is intended for things like 'unittests' so that only the set of targets that are effected by the change get run. To enable the new functionality you have to pass in a new switch. Once I integrate these changes into the rest of the stack. I'll remove the old flow. BUG=109173 TEST=covered by tests R=mark@chromium.org

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 1

Patch Set 3 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+403 lines, -53 lines) Patch
M pylib/gyp/generator/analyzer.py View 1 2 4 chunks +190 lines, -53 lines 0 comments Download
A test/analyzer/gyptest-analyzer.new.py View 1 chunk +170 lines, -0 lines 0 comments Download
M test/analyzer/subdir/subdir.gyp View 1 chunk +17 lines, -0 lines 0 comments Download
M test/analyzer/test.gyp View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
https://codereview.chromium.org/420383002/diff/20001/pylib/gyp/generator/analyzer.py File pylib/gyp/generator/analyzer.py (right): https://codereview.chromium.org/420383002/diff/20001/pylib/gyp/generator/analyzer.py#newcode194 pylib/gyp/generator/analyzer.py:194: raise Exception('Unable to open file ' + config_path) I'm ...
6 years, 4 months ago (2014-07-28 21:02:05 UTC) #1
Mark Mentovai
6 years, 4 months ago (2014-07-28 21:52:43 UTC) #2
LGTM. Exceptions are OK in Python.

Powered by Google App Engine
This is Rietveld 408576698