GN: Specify correct prefix/postfix libs for solink on android

GN: Specify correct prefix/postfix libs for solink on android

On android we have to specify crtbegin_dynamic.o / crtend_android.o when
linking executables and crtbegin_so.o / crtend_so.o when linking shared
libraries. This splits the variables up in gcc_toolchain so the android
template can differentiate between the two.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285991

[jamesr, 2014-07-28 19:34:46]

https://codereview.chromium.org/420353002/diff/1/build/toolchain/gcc_toolchai...
File build/toolchain/gcc_toolchain.gni (right):

https://codereview.chromium.org/420353002/diff/1/build/toolchain/gcc_toolchai...
build/toolchain/gcc_toolchain.gni:100: command = "if [ ! -e \$lib -o ! -e
\${lib}.TOC ]; then $ld -shared \$ldflags -o \$lib -Wl,-soname=\$soname
@\$rspfile && { readelf -d \${lib} | grep SONAME ; nm -gD -f p \${lib} | cut
-f1-2 -d' '; } > \${lib}.TOC; else $ld -shared \$ldflags -o \$lib
-Wl,-soname=\$soname -Wl,--whole-archive \$in \$solibs -Wl,--no-whole-archive
$solink_libs_section_prefix \$libs $solink_libs_section_postfix && { readelf -d
\${lib} | grep SONAME ; nm -gD -f p \${lib} | cut -f1-2 -d' '; } > \${lib}.tmp
&& if ! cmp -s \${lib}.tmp \${lib}.TOC; then mv \${lib}.tmp \${lib}.TOC ; fi;
fi"
i'm not sure i understand the difference between the branches in this if

[jamesr, 2014-07-28 20:38:23]

OK, this seems to work

(I still don't understand the bash conditional here but this links locally
so...)

[brettw, 2014-07-28 20:55:43]

lgtm

[jamesr, 2014-07-28 20:58:02]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-07-28 20:59:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamesr@chromium.org/420353002/20001

[commit-bot: I haz the power, 2014-07-28 21:56:46]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[commit-bot: I haz the power, 2014-07-28 22:03:13]

Change committed as 285991

[jamesr, 2014-07-29 02:13:26]

https://codereview.chromium.org/420353002/diff/20001/build/toolchain/gcc_tool...
File build/toolchain/gcc_toolchain.gni (right):

https://codereview.chromium.org/420353002/diff/20001/build/toolchain/gcc_tool...
build/toolchain/gcc_toolchain.gni:100: command = "if [ ! -e \$lib -o ! -e
\${lib}.TOC ]; then $ld -shared \$ldflags -o \$lib -Wl,-soname=\$soname
@\$rspfile && { readelf -d \${lib} | grep SONAME ; nm -gD -f p \${lib} | cut
-f1-2 -d' '; } > \${lib}.TOC; else $ld -shared \$ldflags -o \$lib
-Wl,-soname=\$soname -Wl,--whole-archive \$in \$solibs -Wl,--no-whole-archive
$solink_libs_section_prefix \$libs $solink_libs_section_postfix && { readelf -d
\${lib} | grep SONAME ; nm -gD -f p \${lib} | cut -f1-2 -d' '; } > \${lib}.tmp
&& if ! cmp -s \${lib}.tmp \${lib}.TOC; then mv \${lib}.tmp \${lib}.TOC ; fi;
fi"
d'oh, I flubbed this and since I didn't realize the branch was about recompiling
didn't catch it when doing local incremental builds.  I'll post a patch to fix
but maybe cjhopman@ will land his better fix to remove this bash conditional
first