Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 420333002: Fix debug output compile error and minor style nits (Closed)

Created:
6 years, 4 months ago by Tom Hudson
Modified:
6 years, 4 months ago
Reviewers:
djsollen, tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M src/ports/SkFontMgr_android.cpp View 5 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tomhudson
PTAL. The build failures were line 133 + 142; the rest is just noise.
6 years, 4 months ago (2014-07-28 18:33:41 UTC) #1
djsollen
lgtm
6 years, 4 months ago (2014-07-28 18:42:37 UTC) #2
tomhudson
The CQ bit was checked by tomhudson@google.com
6 years, 4 months ago (2014-07-28 18:52:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tomhudson@chromium.org/420333002/1
6 years, 4 months ago (2014-07-28 18:53:16 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia ...
6 years, 4 months ago (2014-07-28 19:05:07 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-28 19:09:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/995)
6 years, 4 months ago (2014-07-28 19:09:07 UTC) #7
tomhudson
The CQ bit was checked by tomhudson@google.com
6 years, 4 months ago (2014-07-29 13:49:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tomhudson@chromium.org/420333002/1
6 years, 4 months ago (2014-07-29 13:49:37 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 13:52:43 UTC) #10
Message was sent while issue was closed. 
Change committed as 3a9142437eacf543f5cde6881cc4534868c80f58

Powered by Google App Engine
This is Rietveld 408576698