DescriptionRevert of mac: [Yosemite] Fix bug where zoom button causes fullscreen mode. (reland) (https://codereview.chromium.org/409723004/)
Reason for revert:
[Cocoa Exception] NSInvalidArgumentException reason Unlocking Focus on wrong view (<NSView: 0x#>), expected <FastResizeView: 0x#>
https://code.google.com/p/chromium/issues/detail?id=397089
Original issue's description:
> mac: [Yosemite] Fix bug where zoom button causes fullscreen mode. (reland)
>
> ----------------Reland Description---------------------------
> Fix a type error. NSArray comparators return a NSComparisonResult.
>
> ----------------Original CL Description---------------------------
> In Yosemite, holding down alt while clicking the fullscreen button is supposed
> to zoom the window. This doesn't work because Chrome violates unstated AppKit
> assumptions.
>
> The problem seems to lie in hit testing the location of the zoom button.
> Reordering the subviews by moving the tab strip and the content view behind the
> zoom button fixes the problem.
>
> BUG=393808
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284798
TBR=shess@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=393808
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286044
Patch Set 1 #
Created: 6 years, 4 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|