Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 420323009: Revert of mac: [Yosemite] Fix bug where zoom button causes fullscreen mode. (reland) (Closed)

Created:
6 years, 4 months ago by erikchen
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of mac: [Yosemite] Fix bug where zoom button causes fullscreen mode. (reland) (https://codereview.chromium.org/409723004/) Reason for revert: [Cocoa Exception] NSInvalidArgumentException reason Unlocking Focus on wrong view (<NSView: 0x#>), expected <FastResizeView: 0x#> https://code.google.com/p/chromium/issues/detail?id=397089 Original issue's description: > mac: [Yosemite] Fix bug where zoom button causes fullscreen mode. (reland) > > ----------------Reland Description--------------------------- > Fix a type error. NSArray comparators return a NSComparisonResult. > > ----------------Original CL Description--------------------------- > In Yosemite, holding down alt while clicking the fullscreen button is supposed > to zoom the window. This doesn't work because Chrome violates unstated AppKit > assumptions. > > The problem seems to lie in hit testing the location of the zoom button. > Reordering the subviews by moving the tab strip and the content view behind the > zoom button fixes the problem. > > BUG=393808 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284798 TBR=shess@chromium.org NOTREECHECKS=true NOTRY=true BUG=393808 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -41 lines) Patch
M chrome/browser/ui/cocoa/version_independent_window.mm View 3 chunks +6 lines, -41 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
erikchen
Created Revert of mac: [Yosemite] Fix bug where zoom button causes fullscreen mode. (reland)
6 years, 4 months ago (2014-07-29 01:30:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/420323009/1
6 years, 4 months ago (2014-07-29 01:31:37 UTC) #2
commit-bot: I haz the power
Change committed as 286044
6 years, 4 months ago (2014-07-29 01:33:35 UTC) #3
Scott Hess - ex-Googler
6 years, 4 months ago (2014-07-29 01:42:54 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698