Issue 420323006: Merge 284648 "Changed AppListDialogContentsView to extend Dialog..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 420323006: Merge 284648 "Changed AppListDialogContentsView to extend Dialog..." (Closed)

Created:
6 years, 4 months ago by sashab

Modified:
6 years, 4 months ago

Reviewers:
sashab

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/branches/2062/src/

Project:
chromium

Visibility:
Public.

Merge 284648 "Changed AppListDialogContentsView to extend Dialog..." > Changed AppListDialogContentsView to extend DialogDelegate > > Originally, AppListDialogContentsView extended WidgetDelegate directly, > and was not being detected as a dialog correctly on some platforms. > Updated AppListDialogContentsView to now be a DialogDelegate. > > BUG=388637 > > Review URL: https://codereview.chromium.org/405873003 TBR=sashab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286015

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -7 lines)			Patch
	M	chrome/browser/ui/views/app_list/app_list_dialog_contents_view.h	View		3 chunks	+2 lines, -3 lines	0 comments	Download
	M	chrome/browser/ui/views/app_list/app_list_dialog_contents_view.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r286015.