Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 420323002: Move Node::lastDescendantOrSelf() to NodeTraversal and rename to lastWithinOrSelf() (Closed)

Created:
6 years, 4 months ago by Inactive
Modified:
6 years, 4 months ago
Reviewers:
esprehn, adamk
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Move Node::lastDescendantOrSelf() to NodeTraversal and rename to lastWithinOrSelf() Move Node::lastDescendantOrSelf() to NodeTraversal and rename to lastWithinOrSelf() as this is a node traversal utility function and it avoids code duplication with NodeTraversal::lastWithin(). R=esprehn@chromium.org, adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179062

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M Source/core/dom/Node.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/dom/NodeTraversal.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/dom/NodeTraversal.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/editing/DeleteSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Inactive
6 years, 4 months ago (2014-07-28 20:31:44 UTC) #1
adamk
lgtm
6 years, 4 months ago (2014-07-28 20:57:40 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-07-28 20:58:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/420323002/1
6 years, 4 months ago (2014-07-28 20:58:58 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 4 months ago (2014-07-28 21:01:44 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-28 21:04:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/11279)
6 years, 4 months ago (2014-07-28 21:04:17 UTC) #7
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-07-28 21:27:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/420323002/20001
6 years, 4 months ago (2014-07-28 21:28:10 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-07-28 23:00:46 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 23:11:25 UTC) #11
Message was sent while issue was closed.
Change committed as 179062

Powered by Google App Engine
This is Rietveld 408576698