[Android] Fix DeviceUtils.__str__ when no serial is provided.

[Android] Fix DeviceUtils.__str__ when no serial is provided.

This CL also changes two instances of DeviceUtils.__init__(None) s.t.
an explicit serial number is now provided.

BUG=398127
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286124

[frankf, 2014-07-28 22:52:31]

https://codereview.chromium.org/420273006/diff/1/chrome/test/chromedriver/tes...
File chrome/test/chromedriver/test/test_environment.py (right):

https://codereview.chromium.org/420273006/diff/1/chrome/test/chromedriver/tes...
chrome/test/chromedriver/test/test_environment.py:100: if not len(devices):
if not devices:

https://codereview.chromium.org/420273006/diff/1/chrome/test/chromedriver/tes...
chrome/test/chromedriver/test/test_environment.py:101: raise
device_errors.DeviceUnreachableError('No devices attached.')
doesn't this warrant a new type of exception, DeviceUnreachableError is
per-device right?

https://codereview.chromium.org/420273006/diff/1/tools/android/mempressure.py
File tools/android/mempressure.py (right):

https://codereview.chromium.org/420273006/diff/1/tools/android/mempressure.py...
tools/android/mempressure.py:90: if not len(devices):
if not devices:

[jbudorick, 2014-07-28 23:05:40]

https://codereview.chromium.org/420273006/diff/1/chrome/test/chromedriver/tes...
File chrome/test/chromedriver/test/test_environment.py (right):

https://codereview.chromium.org/420273006/diff/1/chrome/test/chromedriver/tes...
chrome/test/chromedriver/test/test_environment.py:100: if not len(devices):
On 2014/07/28 22:52:31, frankf wrote:
> if not devices:

Done.

https://codereview.chromium.org/420273006/diff/1/chrome/test/chromedriver/tes...
chrome/test/chromedriver/test/test_environment.py:101: raise
device_errors.DeviceUnreachableError('No devices attached.')
On 2014/07/28 22:52:31, frankf wrote:
> doesn't this warrant a new type of exception, DeviceUnreachableError is
> per-device right?

It is. Added NoDevicesError.

https://codereview.chromium.org/420273006/diff/1/tools/android/mempressure.py
File tools/android/mempressure.py (right):

https://codereview.chromium.org/420273006/diff/1/tools/android/mempressure.py...
tools/android/mempressure.py:90: if not len(devices):
On 2014/07/28 22:52:31, frankf wrote:
> if not devices:

Done.

[frankf, 2014-07-28 23:08:28]

lgtm

https://codereview.chromium.org/420273006/diff/20001/build/android/pylib/devi...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/420273006/diff/20001/build/android/pylib/devi...
build/android/pylib/device/device_utils.py:795: s =
self.old_interface.Adb().GetSerialNumber()
can this be None as well?

[jbudorick, 2014-07-28 23:19:29]

On 2014/07/28 23:08:28, frankf wrote:
> lgtm
> 
>
https://codereview.chromium.org/420273006/diff/20001/build/android/pylib/devi...
> File build/android/pylib/device/device_utils.py (right):
> 
>
https://codereview.chromium.org/420273006/diff/20001/build/android/pylib/devi...
> build/android/pylib/device/device_utils.py:795: s =
> self.old_interface.Adb().GetSerialNumber()
> can this be None as well?

This calls adb get-serialno. If no devices are attached, it will come back with
'unknown'. It's a string, but subsequent calls to the DeviceUtils instance are
unlikely to succeed. What do you think about checking for 'unknown' and raising
a NoDevicesError on a match?

[craigdh, 2014-07-28 23:28:12]

On 2014/07/28 23:19:29, jbudorick wrote:
> On 2014/07/28 23:08:28, frankf wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/420273006/diff/20001/build/android/pylib/devi...
> > File build/android/pylib/device/device_utils.py (right):
> > 
> >
>
https://codereview.chromium.org/420273006/diff/20001/build/android/pylib/devi...
> > build/android/pylib/device/device_utils.py:795: s =
> > self.old_interface.Adb().GetSerialNumber()
> > can this be None as well?
> 
> This calls adb get-serialno. If no devices are attached, it will come back
with
> 'unknown'. It's a string, but subsequent calls to the DeviceUtils instance are
> unlikely to succeed. What do you think about checking for 'unknown' and
raising
> a NoDevicesError on a match?

Sounds much more reasonable than silently doing the wrong thing.

[jbudorick, 2014-07-28 23:40:54]

On 2014/07/28 23:28:12, craigdh wrote:
> On 2014/07/28 23:19:29, jbudorick wrote:
> > On 2014/07/28 23:08:28, frankf wrote:
> > > lgtm
> > > 
> > >
> >
>
https://codereview.chromium.org/420273006/diff/20001/build/android/pylib/devi...
> > > File build/android/pylib/device/device_utils.py (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/420273006/diff/20001/build/android/pylib/devi...
> > > build/android/pylib/device/device_utils.py:795: s =
> > > self.old_interface.Adb().GetSerialNumber()
> > > can this be None as well?
> > 
> > This calls adb get-serialno. If no devices are attached, it will come back
> with
> > 'unknown'. It's a string, but subsequent calls to the DeviceUtils instance
are
> > unlikely to succeed. What do you think about checking for 'unknown' and
> raising
> > a NoDevicesError on a match?
> 
> Sounds much more reasonable than silently doing the wrong thing.

Done.

[jbudorick, 2014-07-28 23:51:57]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-07-28 23:53:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbudorick@chromium.org/420273006/40001

[commit-bot: I haz the power, 2014-07-29 01:47:34]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-07-29 08:15:01]

Change committed as 286124