Issue 420273005: Oilpan: Remove Document* pointers in objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 420273005: Oilpan: Remove Document* pointers in objects (Closed)

Created:
6 years, 4 months ago by haraken

Modified:
6 years, 4 months ago

Reviewers:
oilpan-reviews, tkent

CC:
blink-reviews, kenneth.christiansen, blink-reviews-rendering, zoltan1, blink-reviews-css, sof, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr., rune+blink, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: Remove Document* pointers in objects This CL replaces Document* pointers in objects with Member<Document>s. - Move TextAutosizer to oilpan's heap. - Move FastTextAutosizer to oilpan's heap. - Make FastBulider STACK_ALLOCATED. - Make ViewportStyleResolver::m_document a Member. BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179066

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -16 lines)			Patch
M	Source/core/css/resolver/FontBuilder.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/core/css/resolver/FontBuilder.cpp	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/core/css/resolver/ViewportStyleResolver.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/resolver/ViewportStyleResolver.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/dom/Document.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/rendering/FastTextAutosizer.h	View	1	4 chunks	+7 lines, -5 lines	0 comments	Download
M	Source/core/rendering/FastTextAutosizer.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/rendering/TextAutosizer.h	View	1	3 chunks	+9 lines, -4 lines	0 comments	Download
M	Source/core/rendering/TextAutosizer.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/420273005/20001

6 years, 4 months ago (2014-07-28 23:27:57 UTC) #3

Message was sent while issue was closed.

Change committed as 179066

Expand Messages | Collapse Messages