Track size of incremental marking steps in GCTracer.

src/gc-tracer.h

Index: src/gc-tracer.h
diff --git a/src/gc-tracer.h b/src/gc-tracer.h
index b1e5c5d0c6c243ecd3d2b26f4a00543ec0bb4bea..8d7bf90cd9ba62a94db6d328a97fd032adb00bb8 100644
--- a/src/gc-tracer.h
+++ b/src/gc-tracer.h
@@ -172,10 +172,28 @@ class GCTracer BASE_EMBEDDED {
 
     // Number of incremental marking steps since creation of tracer.
     // (value at start of event)
+    int cumulative_incremental_marking_steps;
+
+    // Incremental marking steps since
+    // - last event for SCAVENGER events
+    // - last MARK_COMPACTOR event for MARK_COMPACTOR events
     int incremental_marking_steps;
 
+    // Bytes marked since creation of tracer (value at start of event).
+    intptr_t cumulative_incremental_marking_bytes;
+
+    // Bytes marked since
+    // - last event for SCAVENGER events
+    // - last MARK_COMPACTOR event for MARK_COMPACTOR events
+    intptr_t incremental_marking_bytes;
+
     // Cumulative duration of incremental marking steps since creation of
     // tracer. (value at start of event)
+    double cumulative_incremental_marking_duration;
+
+    // Duration of incremental marking steps since
+    // - last event for SCAVENGER events
+    // - last MARK_COMPACTOR event for MARK_COMPACTOR events
     double incremental_marking_duration;
 
     // Longest incremental marking step since start of marking.
@@ -200,7 +218,7 @@ class GCTracer BASE_EMBEDDED {
   void Stop();
 
   // Log an incremental marking step.
-  void AddIncrementalMarkingStep(double duration);
+  void AddIncrementalMarkingStep(double duration, intptr_t bytes);
 
   // Compute the mean duration of the last scavenger events. Returns 0 if no
   // events have been recorded.
@@ -232,6 +250,10 @@ class GCTracer BASE_EMBEDDED {
   // Returns 0 if no incremental marking round has been completed.
   double MaxIncrementalMarkingDuration() const;
 
+  // Compute the average incremental marking speed in bytes/second. Returns 0 if
+  // no events have been recorded.
+  double MarkingSpeedInBytesPerMillisecond() const;

[Hannes Payer (out of office), 2014/07/28 13:04:13]

No need for double here, lets cast it to e.g. intptr_t. I assume that the result
will always be a large number.

[ernstm, 2014/07/28 14:43:26]

Done.

+
  private:
   // Print one detailed trace line in name=value format.
   // TODO(ernstm): Move to Heap.
@@ -267,10 +289,14 @@ class GCTracer BASE_EMBEDDED {
   EventBuffer mark_compactor_events_;
 
   // Cumulative number of incremental marking steps since creation of tracer.
-  int incremental_marking_steps_;
+  int cumulative_incremental_marking_steps_;
+
+  // Cumulative size of incremental marking steps (in bytes) since creation of
+  // tracer.
+  intptr_t cumulative_incremental_marking_bytes_;
 
   // Cumulative duration of incremental marking steps since creation of tracer.
-  double incremental_marking_duration_;
+  double cumulative_incremental_marking_duration_;
 
   // Longest incremental marking step since start of marking.
   double longest_incremental_marking_step_;