Issue 420183004: Force linking as C++ library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 420183004: Force linking as C++ library. (Closed)

Created:
6 years, 4 months ago by mtklein_C

Modified:
6 years, 4 months ago

Reviewers:
bungeman-skia, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, --1 lines)			Patch
A +	expectations/skimage/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared/expected-results.json	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	gyp/skia_lib.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	src/core/SkForceCPlusPlusLinking.cpp	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

bungeman-skia

lgtm It would be nice if gyp itself supported this, essentially by tracking that we ...

6 years, 4 months ago (2014-08-04 19:33:18 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/420183004/20001

6 years, 4 months ago (2014-08-04 19:41:28 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-04 19:51:27 UTC) #5

Message was sent while issue was closed.

Change committed as ad82ed67dfa5514a17dcca0412c81756b3b03095