Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: Source/devtools/front_end/network/NetworkPanel.js

Issue 420183003: DevTools: NetworkPanel: support "selfNodeHeight" contract. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/network/NetworkPanel.js
diff --git a/Source/devtools/front_end/network/NetworkPanel.js b/Source/devtools/front_end/network/NetworkPanel.js
index 28ef9471e0777441832aafa894df62fa5bc8fd3a..9b8a5938fdc9fc9f8fc95c79cfd9686766742b64 100644
--- a/Source/devtools/front_end/network/NetworkPanel.js
+++ b/Source/devtools/front_end/network/NetworkPanel.js
@@ -83,6 +83,8 @@ WebInspector.NetworkLogView = function(filterBar, coulmnsVisibilitySetting)
this._initializeView();
this._recordButton.toggled = true;
+ this._rowHeight = 41;
lushnikov 2014/07/28 16:33:56 = 0 + @type + call _setLargerRequests unconditiona
eustas 2014/07/29 07:00:29 Done.
+
WebInspector.targetManager.observeTargets(this);
WebInspector.targetManager.addModelListener(WebInspector.NetworkManager, WebInspector.NetworkManager.EventTypes.RequestStarted, this._onRequestStarted, this);
WebInspector.targetManager.addModelListener(WebInspector.NetworkManager, WebInspector.NetworkManager.EventTypes.RequestUpdated, this._onRequestUpdated, this);
@@ -972,16 +974,26 @@ WebInspector.NetworkLogView.prototype = {
},
/**
+ * @return {number}
+ */
+ rowHeight: function()
+ {
+ return this._rowHeight;
+ },
+
+ /**
* @param {boolean} enabled
*/
_setLargerRequests: function(enabled)
{
this._largerRequestsButton.toggled = enabled;
if (!enabled) {
+ this._rowHeight = 41;
this._largerRequestsButton.title = WebInspector.UIString("Use large resource rows.");
this._dataGrid.element.classList.add("small");
this._timelineGrid.element.classList.add("small");
} else {
+ this._rowHeight = 21;
this._largerRequestsButton.title = WebInspector.UIString("Use small resource rows.");
this._dataGrid.element.classList.remove("small");
this._timelineGrid.element.classList.remove("small");
@@ -2513,6 +2525,14 @@ WebInspector.NetworkDataGridNode = function(parentView, request)
}
WebInspector.NetworkDataGridNode.prototype = {
+ /**
+ * @override
+ * @return {number}
+ */
+ nodeSelfHeight: function() {
+ return this._parentView.rowHeight();
+ },
+
/** override */
createCells: function()
{
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698