Issue 420183003: DevTools: NetworkPanel: support "selfNodeHeight" contract.

Issue 420183003: DevTools: NetworkPanel: support "selfNodeHeight" contract. (Closed)

Created:
6 years, 4 months ago by eustas

Modified:
6 years, 4 months ago

Reviewers:
vsevik, lushnikov

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: NetworkPanel: support "selfNodeHeight" contract. Supply row height corresponding to current data grid style. BUG=316092 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179115

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -16 lines)			Patch
	M	Source/devtools/front_end/network/NetworkPanel.js	View	1	4 chunks	+27 lines, -16 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

lushnikov

lgtm https://codereview.chromium.org/420183003/diff/1/Source/devtools/front_end/network/NetworkPanel.js File Source/devtools/front_end/network/NetworkPanel.js (right): https://codereview.chromium.org/420183003/diff/1/Source/devtools/front_end/network/NetworkPanel.js#newcode86 Source/devtools/front_end/network/NetworkPanel.js:86: this._rowHeight = 41; = 0 + @type + ...

6 years, 4 months ago (2014-07-28 16:33:57 UTC) #2

eustas

https://codereview.chromium.org/420183003/diff/1/Source/devtools/front_end/network/NetworkPanel.js File Source/devtools/front_end/network/NetworkPanel.js (right): https://codereview.chromium.org/420183003/diff/1/Source/devtools/front_end/network/NetworkPanel.js#newcode86 Source/devtools/front_end/network/NetworkPanel.js:86: this._rowHeight = 41; On 2014/07/28 16:33:56, lushnikov wrote: > ...

6 years, 4 months ago (2014-07-29 07:00:29 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/420183003/20001

6 years, 4 months ago (2014-07-29 07:59:21 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 4 months ago (2014-07-29 09:07:34 UTC) #6

Message was sent while issue was closed.

Change committed as 179115

Expand Messages | Collapse Messages