Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 42018: Initial pass at copy/paste. Menu items are always enabled. This matches Windo... (Closed)

Created:
11 years, 9 months ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Initial pass at copy/paste. Menu items are always enabled. This matches Windows; we'll do better soon. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11444

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -9 lines) Patch
M chrome/app/nibs/en.lproj/TabContents.xib View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/tab_contents/web_contents_view_mac.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/web_contents_view_mac.mm View 1 2 4 chunks +27 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Avi (use Gerrit)
Depends on 42012, but this is basic cut/paste.
11 years, 9 months ago (2009-03-10 18:25:49 UTC) #1
pink (ping after 24hrs)
LGTM with 1 nit. http://codereview.chromium.org/42018/diff/1/3 File chrome/browser/tab_contents/web_contents_view_mac.h (right): http://codereview.chromium.org/42018/diff/1/3#newcode21 Line 21: @private indent @private one ...
11 years, 9 months ago (2009-03-10 18:35:30 UTC) #2
Avi (use Gerrit)
http://codereview.chromium.org/42018/diff/1/3 File chrome/browser/tab_contents/web_contents_view_mac.h (right): http://codereview.chromium.org/42018/diff/1/3#newcode21 Line 21: @private On 2009/03/10 18:35:31, pink wrote: > indent ...
11 years, 9 months ago (2009-03-10 18:39:41 UTC) #3
Avi (use Gerrit)
Now includes turning off rich text for the edit box so it doesn't die when ...
11 years, 9 months ago (2009-03-11 14:48:25 UTC) #4
pink (ping after 24hrs)
11 years, 9 months ago (2009-03-11 14:51:57 UTC) #5
still LGTM

Powered by Google App Engine
This is Rietveld 408576698