Issue 42018: Initial pass at copy/paste. Menu items are always enabled. This matches Windo...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42018: Initial pass at copy/paste. Menu items are always enabled. This matches Windo... (Closed)

Created:
11 years, 9 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Initial pass at copy/paste. Menu items are always enabled. This matches Windows; we'll do better soon. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11444

Patch Set 3 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -9 lines)			Patch
M	chrome/app/nibs/en.lproj/TabContents.xib	View		3 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents_view_mac.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents_view_mac.mm	View	1 2	4 chunks	+27 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

LGTM with 1 nit. http://codereview.chromium.org/42018/diff/1/3 File chrome/browser/tab_contents/web_contents_view_mac.h (right): http://codereview.chromium.org/42018/diff/1/3#newcode21 Line 21: @private indent @private one ...

11 years, 9 months ago (2009-03-10 18:35:30 UTC) #2

Avi (use Gerrit)

http://codereview.chromium.org/42018/diff/1/3 File chrome/browser/tab_contents/web_contents_view_mac.h (right): http://codereview.chromium.org/42018/diff/1/3#newcode21 Line 21: @private On 2009/03/10 18:35:31, pink wrote: > indent ...

11 years, 9 months ago (2009-03-10 18:39:41 UTC) #3

Avi (use Gerrit)

Now includes turning off rich text for the edit box so it doesn't die when ...

11 years, 9 months ago (2009-03-11 14:48:25 UTC) #4

still LGTM

Expand Messages | Collapse Messages

Issue 42018: Initial pass at copy/paste. Menu items are always enabled. This matches Windo... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages