Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1224)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/shell/shell_test_base.cc

Issue 420143003: mojo: shell::Context should outlive the shell MessageLoop (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« mojo/shell/desktop/mojo_main.cc ('K') | « mojo/shell/shell_test_base.h ('k') | mojo/shell/shell_test_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/shell_test_base.cc
diff --git a/mojo/shell/shell_test_base.cc b/mojo/shell/shell_test_base.cc
index 2f4f44dc0f259c71b6088e083e588800f48428d5..0fc57a24fb9ab0157aa9bab0f63172a74c9f3926 100644
--- a/mojo/shell/shell_test_base.cc
+++ b/mojo/shell/shell_test_base.cc
@@ -25,6 +25,7 @@ ShellTestBase::~ShellTestBase() {
}
void ShellTestBase::SetUp() {
+ shell_context_.Init();
test_server_.reset(new net::test_server::EmbeddedTestServer());
ASSERT_TRUE(test_server_->InitializeAndWaitUntilReady());
base::FilePath service_dir;
« mojo/shell/desktop/mojo_main.cc ('K') | « mojo/shell/shell_test_base.h ('k') | mojo/shell/shell_test_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698