Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: mojo/shell/shell_test_helper.h

Issue 420143003: mojo: shell::Context should outlive the shell MessageLoop (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix + verify android Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/shell_test_base.cc ('k') | mojo/shell/shell_test_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/shell_test_helper.h
diff --git a/mojo/shell/shell_test_helper.h b/mojo/shell/shell_test_helper.h
index 6d8953c54c20f6fa560f624191e6e95a38dfa067..d6753731697c06cc803459f5e68cd32d6bcaa315 100644
--- a/mojo/shell/shell_test_helper.h
+++ b/mojo/shell/shell_test_helper.h
@@ -32,14 +32,15 @@ class ShellTestHelper {
// Returns a handle to the ServiceManager. ShellTestHelper owns the
// ServiceProvider.
- ServiceManager* service_manager() { return context_->service_manager(); }
+ ServiceManager* service_manager() { return context_.service_manager(); }
// Sets a ServiceLoader for the specified URL. |loader| is ultimately used on
// the thread this class spawns.
void SetLoaderForURL(scoped_ptr<ServiceLoader> loader, const GURL& url);
private:
- scoped_ptr<Context> context_;
+ Context context_;
+ base::MessageLoop shell_loop_;
scoped_ptr<ServiceManager::TestAPI> test_api_;
DISALLOW_COPY_AND_ASSIGN(ShellTestHelper);
};
« no previous file with comments | « mojo/shell/shell_test_base.cc ('k') | mojo/shell/shell_test_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698