Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: mojo/shell/in_process_dynamic_service_runner_unittest.cc

Issue 420143003: mojo: shell::Context should outlive the shell MessageLoop (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix + verify android Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « mojo/shell/dynamic_service_loader_unittest.cc ('k') | mojo/shell/shell_test_base.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/shell/context.h" 5 #include "mojo/shell/context.h"
6 #include "mojo/shell/in_process_dynamic_service_runner.h" 6 #include "mojo/shell/in_process_dynamic_service_runner.h"
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 namespace mojo { 9 namespace mojo {
10 namespace shell { 10 namespace shell {
11 11
12 TEST(InProcessDynamicServiceRunnerTest, NotStarted) { 12 TEST(InProcessDynamicServiceRunnerTest, NotStarted) {
13 Context context;
13 base::MessageLoop loop; 14 base::MessageLoop loop;
14 Context context; 15 context.Init();
15 InProcessDynamicServiceRunner runner(&context); 16 InProcessDynamicServiceRunner runner(&context);
16 // Shouldn't crash or DCHECK on destruction. 17 // Shouldn't crash or DCHECK on destruction.
17 } 18 }
18 19
19 } // namespace shell 20 } // namespace shell
20 } // namespace mojo 21 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/shell/dynamic_service_loader_unittest.cc ('k') | mojo/shell/shell_test_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698