Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: mojo/shell/child_process_host_unittest.cc

Issue 420143003: mojo: shell::Context should outlive the shell MessageLoop (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review 2 Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Note: This file also tests child_process.*. 5 // Note: This file also tests child_process.*.
6 6
7 #include "mojo/shell/child_process_host.h" 7 #include "mojo/shell/child_process_host.h"
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 16 matching lines...) Expand all
27 } 27 }
28 virtual void DidStart(bool success) OVERRIDE { 28 virtual void DidStart(bool success) OVERRIDE {
29 VLOG(2) << "TestChildProcessHostDelegate::DidStart(" << success << ")"; 29 VLOG(2) << "TestChildProcessHostDelegate::DidStart(" << success << ")";
30 base::MessageLoop::current()->QuitWhenIdle(); 30 base::MessageLoop::current()->QuitWhenIdle();
31 } 31 }
32 }; 32 };
33 33
34 typedef testing::Test ChildProcessHostTest; 34 typedef testing::Test ChildProcessHostTest;
35 35
36 TEST_F(ChildProcessHostTest, Basic) { 36 TEST_F(ChildProcessHostTest, Basic) {
37 Context context;
37 base::MessageLoop message_loop( 38 base::MessageLoop message_loop(
38 scoped_ptr<base::MessagePump>(new common::MessagePumpMojo())); 39 scoped_ptr<base::MessagePump>(new common::MessagePumpMojo()));
39 40 context.Init();
40 Context context;
41 TestChildProcessHostDelegate child_process_host_delegate; 41 TestChildProcessHostDelegate child_process_host_delegate;
42 ChildProcessHost child_process_host(&context, 42 ChildProcessHost child_process_host(&context,
43 &child_process_host_delegate, 43 &child_process_host_delegate,
44 ChildProcess::TYPE_TEST); 44 ChildProcess::TYPE_TEST);
45 child_process_host.Start(); 45 child_process_host.Start();
46 message_loop.Run(); 46 message_loop.Run();
47 int exit_code = child_process_host.Join(); 47 int exit_code = child_process_host.Join();
48 VLOG(2) << "Joined child: exit_code = " << exit_code; 48 VLOG(2) << "Joined child: exit_code = " << exit_code;
49 EXPECT_EQ(0, exit_code); 49 EXPECT_EQ(0, exit_code);
50 } 50 }
51 51
52 } // namespace 52 } // namespace
53 } // namespace test 53 } // namespace test
54 } // namespace shell 54 } // namespace shell
55 } // namespace mojo 55 } // namespace mojo
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698