Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: components/invalidation/BUILD.gn

Issue 420113003: components: Fix a couple of the TODO(GYP) todos. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: REBASE Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/core/browser/BUILD.gn ('k') | components/policy/core/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/invalidation/BUILD.gn
diff --git a/components/invalidation/BUILD.gn b/components/invalidation/BUILD.gn
index c58d8d1dee7714baa1f2a17044b1450647deb4a2..1476b479e0e92d4d201340b4f1a864ba1433e684 100644
--- a/components/invalidation/BUILD.gn
+++ b/components/invalidation/BUILD.gn
@@ -81,12 +81,11 @@ static_library("invalidation") {
deps = [
"//base",
- #"//components/gcm_driver", TODO(GYP)
- "//google_apis",
+ "//components/gcm_driver",
"//components/keyed_service/core",
- "//components/signin/core/browser:browser",
"//components/pref_registry",
- #"//components/signin/core/browser", TODO(GYP)
+ "//components/signin/core/browser",
+ "//google_apis",
"//jingle:notifier",
"//sync",
"//third_party/cacheinvalidation",
@@ -124,6 +123,7 @@ static_library("test_support") {
deps = [
"//base",
+ "//components/gcm_driver:test_support",
"//components/keyed_service/core",
"//google_apis",
"//jingle:notifier",
@@ -132,6 +132,5 @@ static_library("test_support") {
"//sync",
"//testing/gmock",
"//third_party/cacheinvalidation",
- #'gcm_driver_test_support', TODO(GYP)
]
}
« no previous file with comments | « components/autofill/core/browser/BUILD.gn ('k') | components/policy/core/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698