Use tighter typing in editing: FormatBlockCommand / FrameSelection

Source/core/editing/FrameSelection.cpp

Index: Source/core/editing/FrameSelection.cpp
diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp
index 25f461116beee88e082c3bb83b2d6873608e00d6..9ff55f99a63bd814f56b23321db10ccd15a3e084 100644
--- a/Source/core/editing/FrameSelection.cpp
+++ b/Source/core/editing/FrameSelection.cpp
@@ -121,7 +121,7 @@ Element* FrameSelection::rootEditableElementOrDocumentElement() const
     return selectionRoot ? selectionRoot : m_frame->document()->documentElement();
 }
 
-Node* FrameSelection::rootEditableElementOrTreeScopeRootNode() const
+ContainerNode* FrameSelection::rootEditableElementOrTreeScopeRootNode() const
 {
     Element* selectionRoot = m_selection.rootEditableElement();
     if (selectionRoot)
@@ -1346,7 +1346,7 @@ void FrameSelection::selectFrameElementInParentIfFullySelected()
 
     // Get to the <iframe> or <frame> (or even <object>) element in the parent frame.
     // FIXME: Doesn't work for OOPI.
-    Element* ownerElement = m_frame->deprecatedLocalOwner();
+    HTMLFrameOwnerElement* ownerElement = m_frame->deprecatedLocalOwner();
     if (!ownerElement)
         return;
     ContainerNode* ownerElementParent = ownerElement->parentNode();
@@ -1624,7 +1624,7 @@ bool FrameSelection::shouldBlinkCaret() const
     if (m_frame->settings() && m_frame->settings()->caretBrowsingEnabled())
         return false;
 
-    Node* root = rootEditableElement();
+    Element* root = rootEditableElement();
     if (!root)
         return false;
 
@@ -1813,11 +1813,10 @@ void FrameSelection::setSelectionFromNone()
     if (!isNone() || !(document->hasEditableStyle() || caretBrowsing))
         return;
 
-    Node* node = document->documentElement();
-    if (!node)
+    Element* documentElement = document->documentElement();
+    if (!documentElement)
         return;
-    Node* body = isHTMLBodyElement(*node) ? node : Traversal<HTMLBodyElement>::next(*node);
-    if (body)
+    if (HTMLBodyElement* body = Traversal<HTMLBodyElement>::firstChild(*documentElement))

[Inactive, 2014/07/26 19:40:22]

See Document::body() at
https://chromium.googlesource.com/chromium/blink/+/master/Source/core/dom/Doc...

We only need to look at direct children of the document element (html element of
HTML documents). Document::body() also looks for HTMLFrameSetElement in addition
to HTMLBodyElement so we cannot simply call Document::body() here (without
changing the behavior).

[eseidel, 2014/07/26 21:16:54]

I guess non-html documents are going the way of the dodo.   This code doesn't
handle <svg> roots, which is probably fine.

[yosin_UTC9, 2014/07/29 04:38:46]

I think purpose of this patch is improving typing. So, it should be

HTMLBodyElement* body = isHTMLBodyElemnt(*node) ?
static_Cast<HTMLBodyElement*>(node) : Traversal<HTMLBodyElement>::next(*node);

I hope another patch will make to use Document::body().

[Inactive, 2014/07/29 12:01:00]

Ok, I'll do this in a separate patch. It just felt wrong to update the typing on
that line but leave the bad logic as is. Anyway, please take a look at the
latest patchset.

         setSelection(VisibleSelection(firstPositionInOrBeforeNode(body), DOWNSTREAM));
 }