Issue 42009: Fix issue 267: Functions now called with global object as receiver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42009: Fix issue 267: Functions now called with global object as receiver. (Closed)

Created:
11 years, 9 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium), Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Issue 267: Calls to arguments in eval-tainted function scope uses global object as receiver.

Patch Set 2 : Now with regression test #

Total comments: 2

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -9 lines)			Patch
M	src/ast.h	View	3 chunks	+10 lines, -3 lines	0 comments	Download
M	src/codegen-arm.cc	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	src/codegen-ia32.cc	View	1 chunk	+8 lines, -3 lines	2 comments	Download
M	src/scopes.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
A	test/mjsunit/regress/regress-267.js	View	1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

http://codereview.chromium.org/42009/diff/10/13 File src/codegen-ia32.cc (right): http://codereview.chromium.org/42009/diff/10/13#newcode3920 Line 3920: frame_->SpillAll(); I know it's not your code, but ...

11 years, 9 months ago (2009-03-10 12:10:10 UTC) #3

Lasse Reichstein

11 years, 9 months ago (2009-03-10 12:21:08 UTC) #4

http://codereview.chromium.org/42009/diff/10/13
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/42009/diff/10/13#newcode3920
Line 3920: frame_->SpillAll();
Done.

Expand Messages | Collapse Messages

Issue 42009: Fix issue 267: Functions now called with global object as receiver. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Now with regression test #

Messages