Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 42007: Fixed a few more incompatibilities (Closed)

Created:
11 years, 9 months ago by Christian Plesner Hansen
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Made the Error prototype into an error. Allow \c at the end of regexps. Throw a type error when calling regexp methods on non-regexps.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M src/messages.js View 1 chunk +11 lines, -2 lines 0 comments Download
M src/parser.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/regexp-delay.js View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-regexp.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Christian Plesner Hansen
11 years, 9 months ago (2009-03-10 11:21:25 UTC) #1
Lasse Reichstein
11 years, 9 months ago (2009-03-10 11:26:46 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698