Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Issue 420053002: Use tighter typing in editing: DeleteSelectionCommand (Closed)

Created:
6 years, 5 months ago by Inactive
Modified:
6 years, 4 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Use tighter typing in editing: DeleteSelectionCommand Use tighter typing in editing to increase code readability. This CL focuses on DeleteSelectionCommand. R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179072

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M Source/core/editing/CompositeEditCommand.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/editing/DeleteSelectionCommand.h View 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/editing/DeleteSelectionCommand.cpp View 1 5 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Inactive
6 years, 5 months ago (2014-07-26 16:02:49 UTC) #1
yosin_UTC9
LGTM It is more readabile. Thanks! Please wait for OWNERS lgtm for committing.
6 years, 4 months ago (2014-07-28 01:01:22 UTC) #2
leviw_travelin_and_unemployed
owners lgtm
6 years, 4 months ago (2014-07-28 21:36:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/420053002/1
6 years, 4 months ago (2014-07-28 21:37:17 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 4 months ago (2014-07-28 21:41:06 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-28 21:43:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/11285)
6 years, 4 months ago (2014-07-28 21:43:32 UTC) #7
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-07-28 22:25:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/420053002/20001
6 years, 4 months ago (2014-07-28 22:26:28 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 00:05:20 UTC) #10
Message was sent while issue was closed.
Change committed as 179072

Powered by Google App Engine
This is Rietveld 408576698