Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 420033003: Fix 64-bit VS2010 build (Closed)

Created:
6 years, 4 months ago by danno
Modified:
6 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -63 lines) Patch
M src/compiler/ast-graph-builder.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/compiler/code-generator.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M src/compiler/generic-node-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/compiler/instruction.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/machine-node-factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/operator.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/schedule.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/structured-machine-assembler.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/unique.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-branch-combine.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-graph-reducer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-instruction-selector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-node-algorithm.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 3 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
6 years, 4 months ago (2014-07-30 16:04:17 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
6 years, 4 months ago (2014-07-30 16:18:21 UTC) #2
danno
6 years, 4 months ago (2014-07-30 16:21:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22722 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698