ifdef a few pieces of extensions code.

ifdef a few pieces of extensions code.

BUG=349436
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287156

[dconnelly, 2014-07-30 07:54:00]

*profile_signin_confirmation_helper* LGTM. I don't think I'm an owner, though.

[Lei Zhang, 2014-07-30 08:25:17]

On 2014/07/30 07:54:00, dconnelly wrote:
> *profile_signin_confirmation_helper* LGTM. I don't think I'm an owner, though.

I am a chrome/ OWNER though.

And +mvanouwerker for c/b/geolocation.

[Michael van Ouwerkerk, 2014-07-30 10:58:33]

https://codereview.chromium.org/420033002/diff/40001/chrome/browser/geolocati...
File chrome/browser/geolocation/geolocation_permission_context_unittest.cc
(right):

https://codereview.chromium.org/420033002/diff/40001/chrome/browser/geolocati...
chrome/browser/geolocation/geolocation_permission_context_unittest.cc:44: #if
defined(ENABLE_EXTENSIONS)
I do appreciate fixing the unit test, but why not do this for
GeolocationPermissionContext itself?

[Lei Zhang, 2014-07-30 18:57:08]

On 2014/07/30 10:58:33, Michael van Ouwerkerk wrote:
>
https://codereview.chromium.org/420033002/diff/40001/chrome/browser/geolocati...
> File chrome/browser/geolocation/geolocation_permission_context_unittest.cc
> (right):
> 
>
https://codereview.chromium.org/420033002/diff/40001/chrome/browser/geolocati...
> chrome/browser/geolocation/geolocation_permission_context_unittest.cc:44: #if
> defined(ENABLE_EXTENSIONS)
> I do appreciate fixing the unit test, but why not do this for
> GeolocationPermissionContext itself?

I already refactored GeolocationPermissionContext in r276263.

[Michael van Ouwerkerk, 2014-07-31 12:41:28]

On 2014/07/30 18:57:08, Lei Zhang wrote:
> On 2014/07/30 10:58:33, Michael van Ouwerkerk wrote:
> >
>
https://codereview.chromium.org/420033002/diff/40001/chrome/browser/geolocati...
> > File chrome/browser/geolocation/geolocation_permission_context_unittest.cc
> > (right):
> > 
> >
>
https://codereview.chromium.org/420033002/diff/40001/chrome/browser/geolocati...
> > chrome/browser/geolocation/geolocation_permission_context_unittest.cc:44:
#if
> > defined(ENABLE_EXTENSIONS)
> > I do appreciate fixing the unit test, but why not do this for
> > GeolocationPermissionContext itself?
> 
> I already refactored GeolocationPermissionContext in r276263.

Ah the ifdefs are in chrome_geolocation_permission_context_extensions.cc - lgtm!

[Lei Zhang, 2014-07-31 19:02:10]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-07-31 19:04:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/420033002/40001

[commit-bot: I haz the power, 2014-07-31 23:46:37]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-01 13:22:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-01 13:22:59]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Lei Zhang, 2014-08-01 19:00:35]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-08-01 19:04:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/420033002/40001

[commit-bot: I haz the power, 2014-08-02 05:46:28]

Change committed as 287156