Chromium Code Reviews| Index: chrome/browser/component_updater/default_component_installer.h |
| diff --git a/chrome/browser/component_updater/default_component_installer.h b/chrome/browser/component_updater/default_component_installer.h |
| index 10bdcc3bbfe43bec1c61a04b2f289c24e5d644b3..4dd5f7995e53594a4a615bf026ef96296202328d 100644 |
| --- a/chrome/browser/component_updater/default_component_installer.h |
| +++ b/chrome/browser/component_updater/default_component_installer.h |
| @@ -24,7 +24,7 @@ class FilePath; |
| // class. |
| class ComponentInstallerTraits { |
| public: |
| - virtual ~ComponentInstallerTraits() {} |
| + virtual ~ComponentInstallerTraits(); |
| // Verifies that a working installation resides within the directory specified |
| // by |dir|. |dir| is of the form <base directory>/<version>. |
| @@ -49,10 +49,13 @@ class ComponentInstallerTraits { |
| // notified of a successful install, and is meant to support follow-on work |
| // such as updating paths elsewhere in Chrome. Called only from the FILE |
| // thread. |
| - // |version| is the version of the component, while |path| is the path to the |
| - // install directory. |
| - virtual void ComponentReady(const base::Version& version, |
| - const base::FilePath& install_dir) = 0; |
| + // |version| is the version of the component. |
| + // |manifest| is the manifest for this version of the component. |
| + // |install_dir| is the path to the install directory for this version. |
|
xhwang
2013/10/25 17:33:22
comment order matches param order.
ddorwin
2013/10/25 19:03:40
Done.
|
| + virtual void ComponentReady( |
| + const base::Version& version, |
| + const base::FilePath& install_dir, |
| + scoped_ptr<base::DictionaryValue> manifest) = 0; |
| // Returns the directory that the installer will place versioned installs of |
| // the component into. |
| @@ -95,6 +98,7 @@ class DefaultComponentInstaller : public ComponentInstaller { |
| base::Version current_version_; |
| std::string current_fingerprint_; |
| + scoped_ptr<base::DictionaryValue> current_manifest_; |
| scoped_ptr<ComponentInstallerTraits> installer_traits_; |
| DISALLOW_COPY_AND_ASSIGN(DefaultComponentInstaller); |