chrome/browser/component_updater/component_updater_service.h - Issue 42003002: Extract supported codecs from CDM component manifest.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/component_updater/component_updater_service.h

Issue 42003002: Extract supported codecs from CDM component manifest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_	5 #ifndef CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_

6 #define CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_	6 #define CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_

7	7

8 #include <string>	8 #include <string>

9 #include <vector>	9 #include <vector>

10	10

(...skipping 182 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
193 virtual void GetComponents(std::vector<CrxComponentInfo>* components) = 0;	193 virtual void GetComponents(std::vector<CrxComponentInfo>* components) = 0;

194	194

195 virtual ~ComponentUpdateService() {}	195 virtual ~ComponentUpdateService() {}

196 };	196 };

197	197

198 // Creates the component updater. You must pass a valid \|config\| allocated on	198 // Creates the component updater. You must pass a valid \|config\| allocated on

199 // the heap which the component updater will own.	199 // the heap which the component updater will own.

200 ComponentUpdateService* ComponentUpdateServiceFactory(	200 ComponentUpdateService* ComponentUpdateServiceFactory(

201 ComponentUpdateService::Configurator* config);	201 ComponentUpdateService::Configurator* config);

202	202

	203 // Deserialize the CRX manifest. The top level must be a dictionary.
	ddorwin 2013/10/24 22:17:03 Is there a better place to put this utility functi Is there a better place to put this utility function that's needed in multiple places? (I put it here because CUS is used throughout this directory.) waffles 2013/10/25 16:53:42 component_updater_service.h is (supposed to be) th Show quoted text On 2013/10/24 22:17:03, ddorwin wrote: > Is there a better place to put this utility function that's needed in multiple > places? (I put it here because CUS is used throughout this directory.) component_updater_service.h is (supposed to be) the public interface to this module; but I agree that component_unpacker.h doesn't really seem appropriate either. More generally I wish we had a class dedicated to understanding .crx items and the various format details surrounding them. Until that day I would rather have this in component_unpacker.h or component_updater_service_internal.h than in component_updater_service.h; cpu@ might have an opinion here, too. (You'll need him for OWNERS review.)
	204 base::DictionaryValue* ReadComponentManifest(const base::FilePath& unpack_path);

	205

203 #endif // CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_	206 #endif // CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_

OLD	NEW