Update clang warnings after r287092.

Update clang warnings after r287092.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=287125

[hans, 2014-08-01 23:29:00]

lgtm

[Nico, 2014-08-01 23:53:05]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-08-01 23:53:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thakis@chromium.org/419973008/1

[commit-bot: I haz the power, 2014-08-01 23:53:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-01 23:53:37]

Failed to apply patch for third_party/libvpx/libvpx.gyp:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  patching file third_party/libvpx/libvpx.gyp
  Hunk #2 FAILED at 173.
  1 out of 2 hunks FAILED -- saving rejects to file
third_party/libvpx/libvpx.gyp.rej

Patch:       third_party/libvpx/libvpx.gyp
Index: libvpx.gyp
===================================================================
--- third_party/libvpx/libvpx.gyp	(revision 285378)
+++ third_party/libvpx/libvpx.gyp	(working copy)
@@ -99,6 +99,12 @@
                 ],
               }],
             ],
+            'clang_warning_flags': [
+              # libvpx heavily relies on implicit enum casting.
+              '-Wno-conversion',
+              # libvpx does `if ((a == b))` in some places.
+              '-Wno-parentheses-equality',
+            ],
           },
           'dependencies': [
             'gen_asm_offsets_vp8',
@@ -167,20 +173,6 @@
                 }],
               ],
             }],
-            ['clang == 1', {
-              'xcode_settings': {
-                'WARNING_CFLAGS': [
-                  # libvpx heavily relies on implicit enum casting.
-                  '-Wno-conversion',
-                  # libvpx does `if ((a == b))` in some places.
-                  '-Wno-parentheses-equality',
-                ],
-              },
-              'cflags': [
-                '-Wno-conversion',
-                '-Wno-parentheses-equality',
-              ],
-            }],
             ['chromeos == 1', {
               # ChromeOS needs these files for animated WebM avatars.
               'sources': [

[Nico, 2014-08-01 23:58:46]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-08-01 23:59:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thakis@chromium.org/419973008/20001

[commit-bot: I haz the power, 2014-08-01 23:59:33]

Change committed as 287125