Issue 419973006: Update .isolate files for linux_chromeos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 419973006: Update .isolate files for linux_chromeos. (Closed)

Created:
6 years, 4 months ago by jam

Modified:
6 years, 4 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Update .isolate files for linux_chromeos. R=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285842

Patch Set 1 : #

Patch Set 2 : restore fr.pak #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -32 lines)			Patch
M	chrome/browser_tests.isolate	View		6 chunks	+18 lines, -12 lines	0 comments	Download
M	chrome/interactive_ui_tests.isolate	View	1	3 chunks	+19 lines, -12 lines	0 comments	Download
M	chrome/sync_integration_tests.isolate	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/unit_tests.isolate	View	1	3 chunks	+11 lines, -7 lines	0 comments	Download
M	content/content_browsertests.isolate	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Removing fr.pak means the tests won't pass on my machine anymore. Maybe add all of ...

6 years, 4 months ago (2014-07-27 02:25:34 UTC) #2

jam

6 years, 4 months ago (2014-07-27 22:08:23 UTC) #3

On 2014/07/27 02:25:34, M-A Ruel wrote:
> Removing fr.pak means the tests won't pass on my machine anymore. Maybe add
all
> of them? No strong opinion.

ah, that's why it was there. I restored them now, in another cl I'll look into
making the tests always use en-US. it's fragile that they use the user's
language, since if it changes on a VM that the test would fail.

> 
> lgtm

Expand Messages | Collapse Messages