Issue 419973005: Convert WriteMessage...() to use the new user pointer handling (see r285350).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 419973005: Convert WriteMessage...() to use the new user pointer handling (see r285350). (Closed)

Created:
6 years, 5 months ago by viettrungluu

Modified:
6 years, 5 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Convert WriteMessage...() to use the new user pointer handling (see r285350). Also add a |GetArray()| method to |UserPointer<>|. And fix a bug in my previous change to convert ReadMessage...() (which I'm too lazy to update) in |PutArray()|. (And also "restore"/convert one of the ReadMessage...() tests ... which lead me to finding that bug.) R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285709

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+192 lines, -166 lines)			Patch
M	mojo/system/core.cc	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	mojo/system/core_test_base.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	mojo/system/core_unittest.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	mojo/system/dispatcher.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/system/dispatcher.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/system/dispatcher_unittest.cc	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	mojo/system/memory.h	View	2 chunks	+17 lines, -8 lines	0 comments	Download
M	mojo/system/message_in_transit.h	View	3 chunks	+9 lines, -0 lines	0 comments	Download
M	mojo/system/message_in_transit.cc	View	3 chunks	+29 lines, -13 lines	0 comments	Download
M	mojo/system/message_pipe.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/system/message_pipe.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	mojo/system/message_pipe_dispatcher.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/system/message_pipe_dispatcher.cc	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	mojo/system/message_pipe_dispatcher_unittest.cc	View	6 chunks	+58 lines, -26 lines	0 comments	Download
M	mojo/system/message_pipe_unittest.cc	View	11 chunks	+24 lines, -39 lines	0 comments	Download
M	mojo/system/multiprocess_message_pipe_unittest.cc	View	7 chunks	+16 lines, -31 lines	0 comments	Download
M	mojo/system/remote_message_pipe_unittest.cc	View	10 chunks	+20 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

6 years, 5 months ago (2014-07-25 22:22:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r285709 (presubmit successful).

Expand Messages | Collapse Messages