Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 419973003: Disable exceptions on Windows in all builds (take 4) (Closed)

Created:
6 years, 5 months ago by hans
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Disable exceptions on Windows in all builds (take 4) They were previously enabled in shared_library builds for historical reasons. Turning them off makes things nice and consistent across all build types, and helps the Windows Clang build, which currently doesn't support exceptions. Previous attemps failed due to: - mojo_public_environment_unittests unreachable code warning in DrMemory shared_library Release builds (crbug.com/397465) Fixed in Chromium r285674. - chrome_elf_unittests on x64 (crbug.com/396244) Fixed in Chromium r285377. - blink_platform_unittests:DateTimeFormatTest.CommonPattern et al. Fixed in Blink r176189 BUG=82385 TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285676

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M build/common.gypi View 3 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hans
Committed patchset #1 manually as r285676 (presubmit successful).
6 years, 5 months ago (2014-07-25 21:02:46 UTC) #1
Nico
lgtm
6 years, 5 months ago (2014-07-25 21:07:03 UTC) #2
hans
6 years, 5 months ago (2014-07-25 21:18:43 UTC) #3
Message was sent while issue was closed.
On 2014/07/25 21:07:03, Nico (away) wrote:
> lgtm

(I have no idea why it didn't use my @chromium.org address in the commit :/ )

Powered by Google App Engine
This is Rietveld 408576698