Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Side by Side Diff: build/set_clang_warning_flags.gypi

Issue 419963004: clang/win: use clang_warning_flags, like mac and linux do (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file is meant to be included to set clang-specific compiler flags. 5 # This file is meant to be included to set clang-specific compiler flags.
6 # To use this the following variable can be defined: 6 # To use this the following variable can be defined:
7 # clang_warning_flags: list: Compiler flags to pass to clang. 7 # clang_warning_flags: list: Compiler flags to pass to clang.
8 # clang_warning_flags_unset: list: Compiler flags to not pass to clang. 8 # clang_warning_flags_unset: list: Compiler flags to not pass to clang.
9 # 9 #
10 # Only use this in third-party code. In chromium_code, fix your code to not 10 # Only use this in third-party code. In chromium_code, fix your code to not
(...skipping 21 matching lines...) Expand all
32 'conditions': [ 32 'conditions': [
33 ['clang==1', { 33 ['clang==1', {
34 # This uses >@ instead of @< to also see clang_warning_flags set in 34 # This uses >@ instead of @< to also see clang_warning_flags set in
35 # targets directly, not just the clang_warning_flags in target_defaults. 35 # targets directly, not just the clang_warning_flags in target_defaults.
36 'cflags': [ '>@(clang_warning_flags)' ], 36 'cflags': [ '>@(clang_warning_flags)' ],
37 'cflags!': [ '>@(clang_warning_flags_unset)' ], 37 'cflags!': [ '>@(clang_warning_flags_unset)' ],
38 'xcode_settings': { 38 'xcode_settings': {
39 'WARNING_CFLAGS': ['>@(clang_warning_flags)'], 39 'WARNING_CFLAGS': ['>@(clang_warning_flags)'],
40 'WARNING_CFLAGS!': ['>@(clang_warning_flags_unset)'], 40 'WARNING_CFLAGS!': ['>@(clang_warning_flags_unset)'],
41 }, 41 },
42 'msvs_settings': {
43 'VCCLCompilerTool': {
44 'AdditionalOptions': [ '>@(clang_warning_flags)' ],
45 'AdditionalOptions!': [ '>@(clang_warning_flags_unset)' ],
46 },
47 },
42 }], 48 }],
43 ], 49 ],
44 } 50 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698