Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 419963004: clang/win: use clang_warning_flags, like mac and linux do (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
hans
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

clang/win: use clang_warning_flags, like mac and linux do In addition to disabling warnings, this does turn on a few warnings that weren't on before (-Wheader-hygiene, -Wstring-conversions). I'll see how our bot copes, if it's too horrible I might revert this again for a bit. BUG=82385 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287237

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M build/set_clang_warning_flags.gypi View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
I don't have a windows box at hand to test this today, and I don't ...
6 years, 4 months ago (2014-08-01 21:59:10 UTC) #1
hans
lgtm
6 years, 4 months ago (2014-08-01 23:28:33 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-03 00:08:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/419963004/1
6 years, 4 months ago (2014-08-03 00:08:57 UTC) #4
Nico
The CQ bit was unchecked by thakis@chromium.org
6 years, 4 months ago (2014-08-03 01:04:39 UTC) #5
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-03 01:04:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/419963004/1
6 years, 4 months ago (2014-08-03 01:04:50 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-03 01:05:38 UTC) #8
Message was sent while issue was closed.
Change committed as 287237

Powered by Google App Engine
This is Rietveld 408576698