Issue 419933002: Make Mojo's LoggingTest.LogIf resilient to MSVC's unreachable code warning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 419933002: Make Mojo's LoggingTest.LogIf resilient to MSVC's unreachable code warning (Closed)

Created:
6 years, 5 months ago by hans

Modified:
6 years, 5 months ago

Reviewers:
viettrungluu, zhaoqin1

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make Mojo's LoggingTest.LogIf resilient to MSVC's unreachable code warning The test would fail to compile (warning treated as error) in certain build configurations (GYP_DEFINES=component=shared_library build_for_tool=drmemory, with exceptions disabled). Instead of having NotCalled() call abort(), which doesn't return, just use a variable to check that the function doesn't get called. BUG=397465 R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285674

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -10 lines)			Patch
	M	mojo/public/cpp/environment/tests/logging_unittest.cc	View		5 chunks	+17 lines, -10 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/419933002/1

6 years, 5 months ago (2014-07-25 19:46:07 UTC) #4

hans

6 years, 5 months ago (2014-07-25 20:56:14 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r285674 (presubmit successful).

Expand Messages | Collapse Messages