Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1507)

Issue 419913005: Reland: Remove some dead app host code. (Closed)

Created:
6 years, 5 months ago by grt (UTC plus 2)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, grt+watch_chromium.org, tfarina, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Reland: Remove some dead app host code. app_host.exe was removed in r220555. This change removes some dead code that was left behind. Specifically: - chrome_launcher_support no longer exposes any methods related to the AppHost. - Chrome's uninstall prompt no longer has a special case to handle suppressing the "delete your profile" checkbox. - Chrome and its installer no longer have a dependency on launcher_support. - The installer no longer supports installing items from the webstore. - GetUntrustedDataValue no longer has consumers and is gone. BUG=297647 R=benwells@chromium.org,huangs@chromium.org,gab@chromium.org TBR=grt@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285715

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -394 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_win.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/uninstall_browser_prompt.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_service_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/uninstall_view.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/uninstall_view.cc View 5 chunks +13 lines, -18 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_installer.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/installer/launcher_support/chrome_launcher_support.h View 1 chunk +0 lines, -54 lines 0 comments Download
M chrome/installer/launcher_support/chrome_launcher_support.cc View 7 chunks +16 lines, -130 lines 0 comments Download
M chrome/installer/setup/install.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/installer/setup/install.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M chrome/installer/setup/setup_constants.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/setup/setup_constants.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 2 chunks +11 lines, -18 lines 0 comments Download
M chrome/installer/util/chrome_app_host_distribution.cc View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/installer/util/google_update_util.h View 2 chunks +0 lines, -14 lines 0 comments Download
M chrome/installer/util/google_update_util.cc View 4 chunks +0 lines, -100 lines 0 comments Download
M chrome/installer/util/util_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/util/util_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
grt (UTC plus 2)
relanding this after r285710 to un-break google chrome builds.
6 years, 5 months ago (2014-07-25 22:33:32 UTC) #1
grt (UTC plus 2)
The CQ bit was checked by grt@chromium.org
6 years, 5 months ago (2014-07-25 22:33:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/419913005/1
6 years, 5 months ago (2014-07-25 22:35:16 UTC) #3
commit-bot: I haz the power
Change committed as 285715
6 years, 5 months ago (2014-07-25 22:54:54 UTC) #4
gab
6 years, 4 months ago (2014-07-28 13:51:39 UTC) #5
Message was sent while issue was closed.
lgtm, in the future I'd advise to re-open the old CL and reland; makes it easier
to see the fix patch set's diff (or no diff in this case); also keeps history in
one place.

(you can re-open a closed CL from "Edit Issue").

Cheers,
Gab

Powered by Google App Engine
This is Rietveld 408576698