Tools/TestResultServer/handlers/testfilehandler.py - Issue 419883002: TestResultsServer: special handling for aggregate file requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/TestResultServer/handlers/testfilehandler.py

Issue 419883002: TestResultsServer: special handling for aggregate file requests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Tools/TestResultServer/handlers/testfilehandler.py

diff --git a/Tools/TestResultServer/handlers/testfilehandler.py b/Tools/TestResultServer/handlers/testfilehandler.py

index 0e9e2dd54f284db82f7ed31c3e15f7f12c2c81b6..b550a1a5c2ccb683d88a38ecba1639e2da4cdb2d 100644

--- a/Tools/TestResultServer/handlers/testfilehandler.py

+++ b/Tools/TestResultServer/handlers/testfilehandler.py

@@ -203,7 +203,7 @@ class GetFile(webapp2.RequestHandler):

json, date = self._get_file_content_from_key(key)

elif test_list_json:

json, date = self._get_test_list_json(master, builder, test_type, build_number)

- elif num_files or not master or not builder or not test_type or not build_number or not name:

+ elif num_files or not master or not builder or not test_type or (not build_number and not JsonResults.is_aggregate_file(name)) or not name:

limit = int(num_files) if num_files else 100

self._get_file_list(master, builder, test_type, build_number, name, before, limit, callback_name)

return

« no previous file with comments | « no previous file | Tools/TestResultServer/model/jsonresults.py » ('j') | no next file with comments »