Source/core/page/Page.cpp - Issue 419863004: Refactor frame detach to work for both local and remote frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/Page.cpp

Issue 419863004: Refactor frame detach to work for both local and remote frames. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix comment typo Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/Page.cpp

diff --git a/Source/core/page/Page.cpp b/Source/core/page/Page.cpp

index 174a7f27a7e6afb0050ba9772f53836421e3923c..5adcfd88e87c16bd55760cd2b411fac45eefbc3c 100644

--- a/Source/core/page/Page.cpp

+++ b/Source/core/page/Page.cpp

@@ -602,8 +602,7 @@ void Page::willBeDestroyed()

{

RefPtr<Frame> mainFrame = m_mainFrame;

- if (mainFrame->isLocalFrame())

- toLocalFrame(mainFrame.get())->loader().frameDetached();

+ mainFrame->detach();

// Disable all agents prior to resetting the frame view.

m_inspectorController->willBeDestroyed();

« no previous file with comments | « Source/core/loader/FrameLoader.cpp ('k') | no next file » | no next file with comments »