Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 419863003: Remove --enable-speech-synthesis flag. (Closed)

Created:
6 years, 4 months ago by deejay
Modified:
6 years, 4 months ago
Reviewers:
dmazzoni, brettw
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, Chris Evans, Tom Sepez, dcheng, inferno, jln (very slow on Chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove --enable-speech-synthesis flag. Now speech synthesis has launched. So we don't need this flag. BUG=350456 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286617

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/runtime_features.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
deejay
PTAL
6 years, 4 months ago (2014-07-30 08:05:49 UTC) #1
dmazzoni
lgtm
6 years, 4 months ago (2014-07-30 15:11:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/djmix.kim@samsung.com/419863003/1
6 years, 4 months ago (2014-07-30 15:12:12 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-30 17:32:05 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-30 17:34:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/993)
6 years, 4 months ago (2014-07-30 17:34:51 UTC) #6
dmazzoni
+brettw for OWNERS approval (We don't need a bunch of separate reviews, just one owner ...
6 years, 4 months ago (2014-07-30 17:42:45 UTC) #7
brettw
lgtm
6 years, 4 months ago (2014-07-30 22:18:17 UTC) #8
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 4 months ago (2014-07-30 22:18:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/djmix.kim@samsung.com/419863003/1
6 years, 4 months ago (2014-07-30 22:20:13 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 22:28:24 UTC) #11
Message was sent while issue was closed.
Change committed as 286617

Powered by Google App Engine
This is Rietveld 408576698