Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: Source/modules/webdatabase/DatabaseBackend.cpp

Issue 419853002: Add explicit destructor to DatabaseBackend.h. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/modules/webdatabase/DatabaseBackend.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 29 matching lines...) Expand all
40 40
41 namespace blink { 41 namespace blink {
42 42
43 DatabaseBackend::DatabaseBackend(DatabaseContext* databaseContext, const String& name, const String& expectedVersion, const String& displayName, unsigned long e stimatedSize) 43 DatabaseBackend::DatabaseBackend(DatabaseContext* databaseContext, const String& name, const String& expectedVersion, const String& displayName, unsigned long e stimatedSize)
44 : DatabaseBackendBase(databaseContext, name, expectedVersion, displayName, e stimatedSize, DatabaseType::Async) 44 : DatabaseBackendBase(databaseContext, name, expectedVersion, displayName, e stimatedSize, DatabaseType::Async)
45 , m_transactionInProgress(false) 45 , m_transactionInProgress(false)
46 , m_isTransactionQueueEnabled(true) 46 , m_isTransactionQueueEnabled(true)
47 { 47 {
48 } 48 }
49 49
50 DatabaseBackend::~DatabaseBackend()
51 {
52 }
53
50 void DatabaseBackend::trace(Visitor* visitor) 54 void DatabaseBackend::trace(Visitor* visitor)
51 { 55 {
52 visitor->trace(m_transactionQueue); 56 visitor->trace(m_transactionQueue);
53 DatabaseBackendBase::trace(visitor); 57 DatabaseBackendBase::trace(visitor);
54 } 58 }
55 59
56 bool DatabaseBackend::openAndVerifyVersion(bool setVersionInNewDatabase, Databas eError& error, String& errorMessage) 60 bool DatabaseBackend::openAndVerifyVersion(bool setVersionInNewDatabase, Databas eError& error, String& errorMessage)
57 { 61 {
58 TaskSynchronizer synchronizer; 62 TaskSynchronizer synchronizer;
59 if (!databaseContext()->databaseThread() || databaseContext()->databaseThrea d()->terminationRequested(&synchronizer)) 63 if (!databaseContext()->databaseThread() || databaseContext()->databaseThrea d()->terminationRequested(&synchronizer))
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 { 166 {
163 return databaseContext()->databaseThread()->transactionClient(); 167 return databaseContext()->databaseThread()->transactionClient();
164 } 168 }
165 169
166 SQLTransactionCoordinator* DatabaseBackend::transactionCoordinator() const 170 SQLTransactionCoordinator* DatabaseBackend::transactionCoordinator() const
167 { 171 {
168 return databaseContext()->databaseThread()->transactionCoordinator(); 172 return databaseContext()->databaseThread()->transactionCoordinator();
169 } 173 }
170 174
171 } // namespace blink 175 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/webdatabase/DatabaseBackend.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698