Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1055)

Issue 419833003: Prefetch must not run on cellular until the user can disable (Closed)

Created:
6 years, 5 months ago by jkarlin
Modified:
6 years, 4 months ago
Reviewers:
gavinp, tburkard
CC:
chromium-reviews, Bence
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Prefetch must not run on cellular until the user can disable it. http://crrev.com/357413004 removed this check. Need to bring it back. BUG=334602 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286529

Patch Set 1 #

Patch Set 2 : Use the new preference if available #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/prefetch/prefetch.cc View 1 2 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
jkarlin
tburkard: Thanks! bnc: fyi
6 years, 5 months ago (2014-07-25 15:12:31 UTC) #1
jkarlin
On 2014/07/25 15:12:31, jkarlin wrote: > tburkard: Thanks! > bnc: fyi Ping? This one has ...
6 years, 4 months ago (2014-07-28 11:44:15 UTC) #2
jkarlin
On 2014/07/28 11:44:15, jkarlin wrote: > On 2014/07/25 15:12:31, jkarlin wrote: > > tburkard: Thanks! ...
6 years, 4 months ago (2014-07-28 17:40:22 UTC) #3
jkarlin
On 2014/07/28 17:40:22, jkarlin wrote: > On 2014/07/28 11:44:15, jkarlin wrote: > > On 2014/07/25 ...
6 years, 4 months ago (2014-07-29 11:19:37 UTC) #4
tburkard
Sorry, on vacation this week.. On Tue, Jul 29, 2014 at 1:19 PM, <jkarlin@chromium.org> wrote: ...
6 years, 4 months ago (2014-07-29 21:06:02 UTC) #5
tburkard
lgtm
6 years, 4 months ago (2014-07-29 21:07:16 UTC) #6
jkarlin
The CQ bit was checked by jkarlin@chromium.org
6 years, 4 months ago (2014-07-30 01:52:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/419833003/20001
6 years, 4 months ago (2014-07-30 01:54:52 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-30 07:57:13 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-30 07:59:56 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/1124) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/1121) ios_rel_device_ninja ...
6 years, 4 months ago (2014-07-30 07:59:56 UTC) #11
jkarlin
On 2014/07/29 21:06:02, tburkard wrote: > Sorry, on vacation this week.. > > > On ...
6 years, 4 months ago (2014-07-30 10:50:02 UTC) #12
jkarlin
The CQ bit was checked by jkarlin@chromium.org
6 years, 4 months ago (2014-07-30 14:02:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/419833003/40001
6 years, 4 months ago (2014-07-30 14:02:46 UTC) #14
jkarlin
The CQ bit was unchecked by jkarlin@chromium.org
6 years, 4 months ago (2014-07-30 15:32:37 UTC) #15
jkarlin
The CQ bit was checked by jkarlin@chromium.org
6 years, 4 months ago (2014-07-30 16:17:25 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/419833003/40001
6 years, 4 months ago (2014-07-30 16:18:39 UTC) #17
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 16:20:36 UTC) #18
Message was sent while issue was closed.
Change committed as 286529

Powered by Google App Engine
This is Rietveld 408576698