|
|
DescriptionPrefetch must not run on cellular until the user can disable
it. http://crrev.com/357413004 removed this check. Need to bring it
back.
BUG=334602
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286529
Patch Set 1 #Patch Set 2 : Use the new preference if available #Patch Set 3 : Rebase #Messages
Total messages: 18 (0 generated)
tburkard: Thanks! bnc: fyi
On 2014/07/25 15:12:31, jkarlin wrote: > tburkard: Thanks! > bnc: fyi Ping? This one has to go in soon. Thanks!
On 2014/07/28 11:44:15, jkarlin wrote: > On 2014/07/25 15:12:31, jkarlin wrote: > > tburkard: Thanks! > > bnc: fyi > > Ping? This one has to go in soon. Thanks! Added gavinp as reviewer as well. Whoever can get to it first please do! Thanks!
On 2014/07/28 17:40:22, jkarlin wrote: > On 2014/07/28 11:44:15, jkarlin wrote: > > On 2014/07/25 15:12:31, jkarlin wrote: > > > tburkard: Thanks! > > > bnc: fyi > > > > Ping? This one has to go in soon. Thanks! > > Added gavinp as reviewer as well. Whoever can get to it first please do! > Thanks! Ping! I need to get this in asap.
Sorry, on vacation this week.. On Tue, Jul 29, 2014 at 1:19 PM, <jkarlin@chromium.org> wrote: > On 2014/07/28 17:40:22, jkarlin wrote: > >> On 2014/07/28 11:44:15, jkarlin wrote: >> > On 2014/07/25 15:12:31, jkarlin wrote: >> > > tburkard: Thanks! >> > > bnc: fyi >> > >> > Ping? This one has to go in soon. Thanks! >> > > Added gavinp as reviewer as well. Whoever can get to it first please do! >> Thanks! >> > > Ping! I need to get this in asap. > > https://codereview.chromium.org/419833003/ > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
lgtm
The CQ bit was checked by jkarlin@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/419833003/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) android_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_chromeos_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...) win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)
On 2014/07/29 21:06:02, tburkard wrote: > Sorry, on vacation this week.. > > > On Tue, Jul 29, 2014 at 1:19 PM, <mailto:jkarlin@chromium.org> wrote: > > > On 2014/07/28 17:40:22, jkarlin wrote: > > > >> On 2014/07/28 11:44:15, jkarlin wrote: > >> > On 2014/07/25 15:12:31, jkarlin wrote: > >> > > tburkard: Thanks! > >> > > bnc: fyi > >> > > >> > Ping? This one has to go in soon. Thanks! > >> > > > > Added gavinp as reviewer as well. Whoever can get to it first please do! > >> Thanks! > >> > > > > Ping! I need to get this in asap. > > > > https://codereview.chromium.org/419833003/ > > > > To unsubscribe from this group and stop receiving emails from it, send an email > to mailto:chromium-reviews+unsubscribe@chromium.org. Thank Timo! And sorry, didn't know you were out.
The CQ bit was checked by jkarlin@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/419833003/40001
The CQ bit was unchecked by jkarlin@chromium.org
The CQ bit was checked by jkarlin@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/419833003/40001
Message was sent while issue was closed.
Change committed as 286529 |