Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 419823002: test_runner: Migrate MockWebMIDIAccessor to Chromium C++ style. (Closed)

Created:
6 years, 5 months ago by Abhishek
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

test_runner: Migrate MockWebMIDIAccessor to Chromium C++ style. Changes: 1) Run clang-format through source and header files. 2) Rename data member variables to use unix_hacker_ style. 3) Rename methods to use CamelCase style. 4) Rename file name to mock_web_midi_accessor. BUG=331299 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285904

Patch Set 1 #

Total comments: 2

Patch Set 2 : added copy & assign #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -109 lines) Patch
M content/content_shell.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D content/shell/renderer/test_runner/MockWebMIDIAccessor.h View 1 chunk +0 lines, -46 lines 0 comments Download
D content/shell/renderer/test_runner/MockWebMIDIAccessor.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
M content/shell/renderer/test_runner/WebTestInterfaces.cpp View 1 chunk +1 line, -1 line 0 comments Download
A content/shell/renderer/test_runner/mock_web_midi_accessor.h View 1 chunk +47 lines, -0 lines 0 comments Download
A content/shell/renderer/test_runner/mock_web_midi_accessor.cc View 1 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Abhishek
PTAL !
6 years, 5 months ago (2014-07-25 12:48:25 UTC) #1
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/419823002/diff/1/content/shell/renderer/test_runner/mock_web_midi_accessor.cc File content/shell/renderer/test_runner/mock_web_midi_accessor.cc (right): https://codereview.chromium.org/419823002/diff/1/content/shell/renderer/test_runner/mock_web_midi_accessor.cc#newcode33 content/shell/renderer/test_runner/mock_web_midi_accessor.cc:33: }; nit. DISALLOW_COPY_AND_ASSIGN(DidStartSessionTask)
6 years, 4 months ago (2014-07-28 09:22:28 UTC) #2
Abhishek
Comments are incorporated. PTAL ! https://codereview.chromium.org/419823002/diff/1/content/shell/renderer/test_runner/mock_web_midi_accessor.cc File content/shell/renderer/test_runner/mock_web_midi_accessor.cc (right): https://codereview.chromium.org/419823002/diff/1/content/shell/renderer/test_runner/mock_web_midi_accessor.cc#newcode33 content/shell/renderer/test_runner/mock_web_midi_accessor.cc:33: }; On 2014/07/28 09:22:28, ...
6 years, 4 months ago (2014-07-28 10:32:38 UTC) #3
Abhishek
The CQ bit was checked by abhishek.a21@samsung.com
6 years, 4 months ago (2014-07-28 10:32:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abhishek.a21@samsung.com/419823002/20001
6 years, 4 months ago (2014-07-28 10:33:26 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-07-28 10:46:37 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-28 10:47:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/34032)
6 years, 4 months ago (2014-07-28 10:47:42 UTC) #8
Abhishek
The CQ bit was checked by abhishek.a21@samsung.com
6 years, 4 months ago (2014-07-28 12:08:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abhishek.a21@samsung.com/419823002/40001
6 years, 4 months ago (2014-07-28 12:08:41 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-28 13:56:13 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 14:35:55 UTC) #12
Message was sent while issue was closed.
Change committed as 285904

Powered by Google App Engine
This is Rietveld 408576698