[Mac] Call dump_syms with the -g flag when building with mac_breakpad=1.

[Mac] Call dump_syms with the -g flag when building with mac_breakpad=1.

This will produce Breakpad symbol files that have CFI data when building for
64-bit.

BUG=393594
R=mark@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285756

[Robert Sesek, 2014-07-25 22:15:40]

I couldn't think of a better way to handle the bundles in this script. If you
have ideas, let me know.

[Mark Mentovai, 2014-07-25 22:28:44]

LGTM otherwise.

https://codereview.chromium.org/419813005/diff/1/chrome/tools/build/mac/dump_...
File chrome/tools/build/mac/dump_product_syms (right):

https://codereview.chromium.org/419813005/diff/1/chrome/tools/build/mac/dump_...
chrome/tools/build/mac/dump_product_syms:123: if [[ -e "${BUNDLED_OPTION}" ]];
then
Use a combination of -f and -x, not -e.

https://codereview.chromium.org/419813005/diff/1/chrome/tools/build/mac/dump_...
chrome/tools/build/mac/dump_product_syms:151: if [ "${DWARF_PATH}" -nt
"${BPAD_SYM_PATH}" ] ; then
You should also check if SRC_PATH is newer than BPAD_SYM_PATH.

[Robert Sesek, 2014-07-25 22:37:36]

https://codereview.chromium.org/419813005/diff/1/chrome/tools/build/mac/dump_...
File chrome/tools/build/mac/dump_product_syms (right):

https://codereview.chromium.org/419813005/diff/1/chrome/tools/build/mac/dump_...
chrome/tools/build/mac/dump_product_syms:123: if [[ -e "${BUNDLED_OPTION}" ]];
then
On 2014/07/25 22:28:43, Mark Mentovai wrote:
> Use a combination of -f and -x, not -e.

Done.

https://codereview.chromium.org/419813005/diff/1/chrome/tools/build/mac/dump_...
chrome/tools/build/mac/dump_product_syms:151: if [ "${DWARF_PATH}" -nt
"${BPAD_SYM_PATH}" ] ; then
On 2014/07/25 22:28:43, Mark Mentovai wrote:
> You should also check if SRC_PATH is newer than BPAD_SYM_PATH.

Done.

[Robert Sesek, 2014-07-25 23:04:27]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2014-07-25 23:06:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rsesek@chromium.org/419813005/20002

[commit-bot: I haz the power, 2014-07-26 05:03:08]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)

[Robert Sesek, 2014-07-26 13:53:32]

The CQ bit was unchecked by rsesek@chromium.org

[Robert Sesek, 2014-07-26 13:53:37]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2014-07-26 13:54:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rsesek@chromium.org/419813005/20002

[Robert Sesek, 2014-07-26 14:03:00]

Committed patchset #2 manually as r285756 (presubmit successful).