Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: test/cctest/test-macro-assembler-x64.cc

Issue 419803009: [x64] Get rid of the stupid SmiConstantRegister. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/x64/macro-assembler-x64.cc ('K') | « src/x64/macro-assembler-x64.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-macro-assembler-x64.cc
diff --git a/test/cctest/test-macro-assembler-x64.cc b/test/cctest/test-macro-assembler-x64.cc
index cfcc5a1b5ede8eb707ef477eca47cb58c412b918..395b38699edb934e9628c66cf7b81adc11de68ac 100644
--- a/test/cctest/test-macro-assembler-x64.cc
+++ b/test/cctest/test-macro-assembler-x64.cc
@@ -98,21 +98,13 @@ typedef int (*F0)();
static void EntryCode(MacroAssembler* masm) {
// Smi constant register is callee save.
- __ pushq(i::kSmiConstantRegister);
__ pushq(i::kRootRegister);
- __ InitializeSmiConstantRegister();
__ InitializeRootRegister();
}
static void ExitCode(MacroAssembler* masm) {
- // Return -1 if kSmiConstantRegister was clobbered during the test.
- __ Move(rdx, Smi::FromInt(1));
- __ cmpq(rdx, i::kSmiConstantRegister);
- __ movq(rdx, Immediate(-1));
- __ cmovq(not_equal, rax, rdx);
__ popq(i::kRootRegister);
- __ popq(i::kSmiConstantRegister);
}
@@ -561,32 +553,6 @@ TEST(SmiCheck) {
cond = masm->CheckNonNegativeSmi(rcx); // "Positive" non-smi.
__ j(cond, &exit);
- // CheckIsMinSmi
-
- __ incq(rax);
- __ movq(rcx, Immediate(Smi::kMaxValue));
- __ Integer32ToSmi(rcx, rcx);
- cond = masm->CheckIsMinSmi(rcx);
- __ j(cond, &exit);
-
- __ incq(rax);
- __ movq(rcx, Immediate(0));
- __ Integer32ToSmi(rcx, rcx);
- cond = masm->CheckIsMinSmi(rcx);
- __ j(cond, &exit);
-
- __ incq(rax);
- __ movq(rcx, Immediate(Smi::kMinValue));
- __ Integer32ToSmi(rcx, rcx);
- cond = masm->CheckIsMinSmi(rcx);
- __ j(NegateCondition(cond), &exit);
-
- __ incq(rax);
- __ movq(rcx, Immediate(Smi::kMinValue + 1));
- __ Integer32ToSmi(rcx, rcx);
- cond = masm->CheckIsMinSmi(rcx);
- __ j(cond, &exit);
-
// CheckBothSmi
__ incq(rax);
« src/x64/macro-assembler-x64.cc ('K') | « src/x64/macro-assembler-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698