Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 419803008: Don't remove -mfpmath=sse when building with clang. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
hans
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Don't remove -mfpmath=sse when building with clang. Clang uses SSE for fpmath by default, so this change shouldn't have an effect in practice, it just makes this code a bit shorter. (This was added almost 4 years ago: http://crrev.com/59882 Clang seems to have learned about the flag since then.) BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287023

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
6 years, 4 months ago (2014-08-01 01:33:57 UTC) #1
hans
lgtm
6 years, 4 months ago (2014-08-01 01:38:54 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-01 01:46:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/419803008/1
6 years, 4 months ago (2014-08-01 01:48:09 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-01 09:33:25 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 17:01:31 UTC) #6
Message was sent while issue was closed.
Change committed as 287023

Powered by Google App Engine
This is Rietveld 408576698