Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(22)

Issue 4198004: Fix a bug that <input type=file multiple> doesn't accept many files.... (Closed)

Created:
10 years, 1 month ago by tkent
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Fix a bug that <input type=file multiple> doesn't accept many files. The old code restricted the total characters of selected files to MAX_PATH (256). It is insufficient for multiple files. The new code uses UNICODE_STRING_MAX_CHARS (32767), which is the maximum string length of Win32 API. Firefox uses 4096. BUG=44068 TEST=No automated test because it's very hard to test the behavior of Windows' file open dialog. Manual test: Make two files on a local disk. The length of their names should be 200 characters. Visit a page with <input type=file multiple>, click the file upload control, and select these two files. The file upload control should show "2 files". Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64037

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/views/shell_dialogs_win.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tkent
10 years, 1 month ago (2010-10-27 06:23:25 UTC) #1
Zachary Kuznia
LGTM
10 years, 1 month ago (2010-10-27 07:12:01 UTC) #2
Matt Perry
10 years, 1 month ago (2010-10-27 18:19:24 UTC) #3
LGTM.

FYI, TEST= is in fact a description of a manual test, for QA to verify, not to
describe unit tests.

Powered by Google App Engine
This is Rietveld 408576698